[PATCH] emxx_udc : Fix #if 0 coding style warning

Greg KH gregkh at linuxfoundation.org
Mon May 27 07:53:03 UTC 2019


On Sun, May 26, 2019 at 11:10:55PM +0300, Yacov Simhony wrote:
> This patch fixes the checkpathc.pl warning:
> WARNING: Consider removing the code enclosed by this #if 0 and its #endif
> 
> Signed-off-by: Yacov Simhony <ysimhony at gmail.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index b8c3dee..985a1fb 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -10,10 +10,8 @@
>  
>  /*---------------------------------------------------------------------------*/
>  /*----------------- Default undef */
> -#if 0
> -#define DEBUG
> -#define UDC_DEBUG_DUMP
> -#endif
> +//#define DEBUG
> +//#define UDC_DEBUG_DUMP

Why not remove any code that depends on this and then these lines?
these are usually only needed while development of the driver happens,
no user is ever going to rebuild the driver with these flags set.

thanks,

greg k-h


More information about the devel mailing list