[PATCH] staging: fieldbus: anybuss: Remove variable
nishka.dasgupta at yahoo.com
Thu May 23 08:22:29 UTC 2019
On 23/05/19 12:52 PM, Greg KH wrote:
> On Thu, May 23, 2019 at 12:35:26PM +0530, Nishka Dasgupta wrote:
>> Variable client, assigned to priv->client, is used only once in a
>> function argument; hence, it can be removed and the function argument
>> replaced with priv->client directly.
>> Issue found with Coccinelle.
>> Signed-off-by: Nishka Dasgupta <nishka.dasgupta at yahoo.com>
>> drivers/staging/fieldbus/anybuss/hms-profinet.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>> diff --git a/drivers/staging/fieldbus/anybuss/hms-profinet.c b/drivers/staging/fieldbus/anybuss/hms-profinet.c
>> index 5446843e35f4..a7f85912fa92 100644
>> --- a/drivers/staging/fieldbus/anybuss/hms-profinet.c
>> +++ b/drivers/staging/fieldbus/anybuss/hms-profinet.c
>> @@ -124,9 +124,7 @@ static int __profi_enable(struct profi_priv *priv)
>> static int __profi_disable(struct profi_priv *priv)
>> - struct anybuss_client *client = priv->client;
>> - anybuss_set_power(client, false);
>> + anybuss_set_power(priv->client, false);
> Same comments are relevant here as the last patch you sent.
So just to clarify this patch isn't necessary and I should cc Sven?
> greg k-h
More information about the devel