[PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

Nishka Dasgupta nishka.dasgupta at yahoo.com
Thu May 23 06:35:01 UTC 2019


In the functions export_reset_0 and export_reset_1 in arcx-anybus.c,
the only operation performed before return is passing the variable cd
(which takes the value of a function call on one of the parameters) as
argument to another function. Hence the variable cd can be removed.
Issue found using Coccinelle.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta at yahoo.com>
---
 drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/fieldbus/anybuss/arcx-anybus.c b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
index 2ecffa42e561..e245f940a5c4 100644
--- a/drivers/staging/fieldbus/anybuss/arcx-anybus.c
+++ b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
@@ -87,16 +87,12 @@ static int anybuss_reset(struct controller_priv *cd,
 
 static void export_reset_0(struct device *dev, bool assert)
 {
-	struct controller_priv *cd = dev_get_drvdata(dev);
-
-	anybuss_reset(cd, 0, assert);
+	anybuss_reset(dev_get_drvdata(dev), 0, assert);
 }
 
 static void export_reset_1(struct device *dev, bool assert)
 {
-	struct controller_priv *cd = dev_get_drvdata(dev);
-
-	anybuss_reset(cd, 1, assert);
+	anybuss_reset(dev_get_drvdata(dev), 1, assert);
 }
 
 /*
-- 
2.19.1



More information about the devel mailing list