[PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies
gregkh at linuxfoundation.org
Wed May 22 12:27:14 UTC 2019
On Wed, May 22, 2019 at 12:13:57PM +0000, Geordan Neukum wrote:
> The kpc2000 core makes calls against functions which are conditionally
> exported upon the kconfig symbols 'MFD_CORE' and 'UIO' being selected
> Therefore, in order to guarantee correct compilation, the 'KPC2000'
> kconfig symbol (which brings in that code) must explicitly select its
> hard dependencies.
> Signed-off-by: Geordan Neukum <gneukum1 at gmail.com>
> drivers/staging/kpc2000/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
> index fb5922928f47..8992dc67ff37 100644
> --- a/drivers/staging/kpc2000/Kconfig
> +++ b/drivers/staging/kpc2000/Kconfig
> @@ -3,6 +3,8 @@
> config KPC2000
> bool "Daktronics KPC Device support"
> depends on PCI
> + select MFD_CORE
> + select UIO
depends on is better than select. There's a change to depend on UIO for
this code already in my -linus branch which will show up in Linus's tree
in a week or so.
Are you sure we need MFD_CORE as well for this code? Why hasn't that
been seen on any build errors?
More information about the devel