[PATCH] staging: fieldbus: solve warning incorrect type dev_core.c

Sven Van Asbroeck thesven73 at gmail.com
Tue May 21 14:13:58 UTC 2019

On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
<oscargomezf at gmail.com> wrote:
> These changes solve a warning realated to an incorrect type inilizer in the function
> fieldbus_poll.
> Signed-off-by: Oscar Gomez Fuente <oscargomezf at gmail.com>
> ---

I've reviewed your patch and tested it on a live system. Everything looks good.
However, I believe that your commit message could be improved.

I am going to re-post this patch as v3 (keeping you as the author) but with
a (hopefully) improved commit message. If you provide positive feedback,
and nobody else has any comments, I will tag it with my Reviewed-by,
which will hopefully be Greg's cue to take the patch.

In the future you could perhaps run your patch through ./scripts/checkpatch.pl
before you post it? This should pick up missing commit messages, lines in the
commit msg that are too long, etc.

More information about the devel mailing list