[PATCH 02/11] staging: kpc2000: add separate show functions for kpc_uio_class device attributes.

Matt Sickler Matt.Sickler at daktronics.com
Thu May 16 20:17:51 UTC 2019


>-----Original Message-----
>From: devel <driverdev-devel-bounces at linuxdriverproject.org> On Behalf Of
>Define separate simple show functions for each attribute instead of having a
>one big one containing a chain of conditionals.
>
>+static ssize_t s2c_dma_ch_show(struct device *dev,
>+                              struct device_attribute *attr, char *buf)
>+{
>+       return 0;
>+}
>+
>+static ssize_t c2s_dma_ch_show(struct device *dev,
>+                              struct device_attribute *attr, char *buf)
>+{
>+       return 0;
>+}

These two can be removed.  Technically, that would be a userspace-breaking
change, but I can guarantee that all existing userspace consumers don't actually
read that sysfs node.


More information about the devel mailing list