[PATCH v2] kpc_i2c: Remove unused file

'gregkh@linuxfoundation.org' gregkh at linuxfoundation.org
Mon May 13 10:09:04 UTC 2019


On Thu, May 09, 2019 at 02:47:50PM +0000, Matt Sickler wrote:
> >-----Original Message-----
> >From: Dan Carpenter <dan.carpenter at oracle.com>
> >
> >Add Staging: to the subject.
> 
> Added to my notes so I don't forget it next time.
> 
> >[PATCH v2] Staging: kpc_i2c: Remove unused file fileops.c
> >
> >On Thu, May 09, 2019 at 01:38:27PM +0000, Matt Sickler wrote:
> >> The whole file was wrapped in an #if 0.  I'm guessing it was a
> >> leftover file from when we were first developing the driver and we just
> >forgot about it.
> >>
> >> V2: Forgot the signed-off-by line on the first patch.
> >
> >Put this after the --- cut off line
> >
> >>
> >> Signed-off-by: Matt Sickler <matt.sickler at daktronics.com>
> >> ---
> >  ^^^
> >
> >Here.
> 
> Noted.  I just looked up a "v2" patch in the mailing list
> archive to see what that looks like.  I'll try to do that
> next time.
> 
> >
> >There is something else wrong with the patch and it's corrupted a bit or
> >something.  Please read the first paragraph of Documentation/process/email-
> >clients.rst
> 
> Ugh.  I'm about to throw Outlook in the trash and just use
> my personal email account.
> I know most subsystem maintainers don't accept pull requests
> but Daktronics does have a github account that I could push
> my changes to and use git-request-pull to ask Greg to pull
> from.  Greg, would that be an acceptable solution?  If not,
> I can continue struggle-bussing with Outlook.

I can't take git pull requests from github, sorry.

Can you use 'git send-email' directly with your exchange server, from
the command line?

I fixed up this patch by hand and applied it.

thanks,

greg k-h


More information about the devel mailing list