[PATCH v2] kpc_i2c: Remove unused file

Dan Carpenter dan.carpenter at oracle.com
Thu May 9 14:55:52 UTC 2019

On Thu, May 09, 2019 at 02:47:50PM +0000, Matt Sickler wrote:
> >> ---
> >  ^^^
> >
> >Here.
> Noted.  I just looked up a "v2" patch in the mailing list
> archive to see what that looks like.  I'll try to do that
> next time.

A few people/subsystems (DRM) put the change log in the commit message
but that's pretty weird and I don't know if they do it on purpose or
they're just not aware how to do it properly...  :P

When it's under the --- then it isn't stored in the permanent git log.

> >
> >There is something else wrong with the patch and it's corrupted a bit or
> >something.  Please read the first paragraph of Documentation/process/email-
> >clients.rst
> Ugh.  I'm about to throw Outlook in the trash and just use
> my personal email account.
> I know most subsystem maintainers don't accept pull requests
> but Daktronics does have a github account that I could push
> my changes to and use git-request-pull to ask Greg to pull
> from.  Greg, would that be an acceptable solution?  If not,
> I can continue struggle-bussing with Outlook.

You can't just use git send-email?  Outlook is going to give you
headaches forever.  I use mutt, but one subsystem only accept patches
from git send-email so I have to add a fake "X-Mailer: git-send-email"
header to my patches...

dan carpenter

More information about the devel mailing list