RFC: kpc2000 driver naming

'gregkh@linuxfoundation.org' gregkh at linuxfoundation.org
Mon May 6 06:20:31 UTC 2019


On Sun, May 05, 2019 at 10:14:17PM +0000, Matt Sickler wrote:
> 
> >-----Original Message-----
> >From: 'gregkh at linuxfoundation.org' <gregkh at linuxfoundation.org>
> >On Fri, May 03, 2019 at 10:24:00PM +0000, Matt Sickler wrote:
> >> Hello,
> >>
> >> Recently Greg KH posted the first set of drivers for our PCIe device
> >(kpc2000) and shortly after that I posted the kpc2000_dma driver.   I was
> >wondering about naming / structure standards in the Linux kernel.
> >> First, a real quick background on these devices:  Daktronics makes a PCIe
> >card with an FPGA on it to drive our LED displays (and other processing tasks).
> >Inside the FPGA, we use something similar to AXI-4 to divide the PCIe BAR
> >register space [1] into separate "IP cores".  The kpc2000 driver is responsible
> >for probing the PCIe device, doing some basic setup (mapping the BAR,
> >setting up an IRQ, PCIe configuration, etc) and then enumerating these
> >"cores".  Enumeration of the cores is facilitated by the "board info" core that is
> >always at the beginning of the BAR and has a defined format.   Most of the
> >cores are controlled entirely by userspace - the driver will add a UIO sub
> >device for each one which userspace uses to control FPGA registers.   Only 3
> >core types are handled by drivers: DMA, I2C, SPI.  These are IP cores inside
> >the FPGA that (in the case of i2c and spi) interact with other physical devices
> >on the PCIe card.
> >> Currently, we only have the one PCIe device (the "P2K" card) but we have
> >more on our roadmap (one we've been calling "p3k" internally).   I'm 99%
> >confident that the I2C and SPI cores will be exactly the same on the new FPGA
> >design.   I'm 80% confident that the DMA engines themselves will be exactly
> >the same on the new FPGA design.   The next card PCIe driver will quite likely
> >be separate from the kpc2000 driver because how bitstreams are stored /
> >loaded / configured is changing due to using a newer FPGA.  There will likely
> >be common code between the two.
> >
> >Please wrap your emails at a sane column, otherwise this is just a huge wall of
> >text that is hard to read/understand.
> 
> We use Outlook and Office 365, so I figured the emails were going to be
> formatted badly.  Just for clarity, are you saying I should hard wrap (insert
> newlines myself) at an 80-column boundary?

If your email client forces that to be the only way, yes :(

> >> Now on to my actual questions: Once the drivers are "good enough" to be
> >moved outside of staging, I'm wondering where the drivers will end up and
> >what their names will/should be.
> >> Since the I2C and SPI drivers are single-file, I'm guessing they're going to
> >move to drivers/i2c/busses/i2c-dak/ and drivers/spi/spi-dak/, respectively.  I
> >tweaked the names, since "i2c-dak" and "spi-dak" make more sense to me
> >than "kpc_i2c" and "kpc_spi".
> >
> >Feel free to rename them to whatever you want, I just randomly picked a
> >name when I did the import of the drivers.
> >
> >> So that leaves the DMA and main PCIe drivers.  Where do those end up in
> >the tree?   Would "dak-dma" and "dak-p2k" (and eventually "dak-p3k") make
> >more sense as names for those drivers?
> >
> >Maybe, as long as it is a "unique" name, that's all that should matter.
> >The subsystem maintainers of those areas might care more, but you can deal
> >with that when you get closer to moving the code out of staging.
> >
> >> The final question relates to how Kconfig entries are setup.   The
> >> I2C, SPI, and DMA drivers could be "selected" on their own (even if
> >> the "dak-p2k" and "dak-p3k" drivers aren't selected), but that doesn't
> >> make much sense because they'd never get used in that configuration.
> >> Conversely, if you select the "dak-p2k" driver, the I2C, SPI, and DMA
> >> drivers better get selected too, otherwise the device won't function
> >> correctly.  From what I can tell with Kconfig, if A depends on B, you
> >> can't even see (let alone select) A without already selecting B.
> >> Right now, the Kconfig entries are setup like this (using the current names,
> >not the new ones presented above):
> >>       KPC2000_DMA depends on KPC2000 (this compiles the kpc2000_dma
> >driver)
> >>       KPC2000_I2C depends on KPC2000 && I2C (this compiles the kpc2000_i2c
> >driver)
> >>       KPC2000_SPI depends on KPC2000 && SPI (this compiles the kpc2000_spi
> >driver)
> >>       KPC2000_CORE depends on  KPC2000
> >>       KPC2000 depends on PCI (this compiles the kpc2000 driver) Greg,
> >> what is the purpose of the KPC2000_CORE config option?  Nothing (that I
> >see) depends on it, and it doesn't cause any code to get compiled.
> >
> >I don't remember, I guess I thought that was a chunk of code the others all
> >depended on being present?  If that's not the case, please send a patch to fix
> >that up.
> 
> The I2C and SPI drivers don't depend on anything other than the I2C and SPI
> subsystems.  Actually, they might be depending on the kp2000 driver having the
> PCIe registers mapped into kernel space instead of doing that themselves.
> I'm not sure if that's the correct thing to do or not, so that might be
> something to look closely at with all these drivers.

Are all of these drivers needed for this hardware to work?  Should they
even be separate drivers or should they all be mushed into one?  Can
anyone do anything useful with just one of them?

> >> I would have thought something like this makes more sense [2]:
> >>       KPC2000_DMA depends nothing
> >
> >Not any dma drivers/core?
> 
> I don't think the DMA driver depends on anything special from other drivers or
> the kernel proper.   Unfortunately, it doesn't use the DMA subsystem, since I
> didn't know about it while I was writing the driver.

Ok, we should take "DMA" off of it then :)

> >>       KPC2000_I2C depends on I2C
> >>       KPC2000_SPI depends on SPI
> >>       KPC2000 depends on PCI && KPC2000_DMA && KPC2000_I2C &&
> >> KPC2000_SPI
> >
> >It can't depend on them all, or does it?  If so, that's fine, I just got this totally
> >backwards, sorry.
> 
> Yes, all 4 drivers are required for proper functioning of the card.  SPI is used
> to reprogram the flash chips that store the FPGA bitstream.  I2C is used for
> monitoring and programming clock generators.  DMA is required for some parts
> of other cores.

So should we just merge this into one driver at link time?  That would
make more sense, right?

thanks,

greg k-h


More information about the devel mailing list