[PATCH v3 08/10] staging: octeon-ethernet: support of_get_mac_address new ERR_PTR error
ynezz at true.cz
Fri May 3 19:07:30 UTC 2019
Dan Carpenter <dan.carpenter at oracle.com> [2019-05-03 13:34:56]:
> On Fri, May 03, 2019 at 09:56:05AM +0200, Petr Štetiar wrote:
> > There was NVMEM support added to of_get_mac_address, so it could now
> > return NULL and ERR_PTR encoded error values, so we need to adjust all
> > current users of of_get_mac_address to this new fact.
> Which commit added NVMEM support? It hasn't hit net-next or linux-next
> yet... Very strange.
this patch is a part of the patch series, where the 1st patch adds this
NVMEM support to of_get_mac_address and follow-up patches are adjusting
current of_get_mac_address users to the new ERR_PTR return value.
> Why would of_get_mac_address() return a mix of NULL and error pointers?
I've introduced this misleading API in v3, but corrected it in v4, so it now
returns only valid pointer or ERR_PTR encoded error value.
Just FYI, changes for staging/octeon are currently at v5.
More information about the devel