[PATCH] staging: most: cdev: fix chrdev_region leak in mod_exit
Christian.Gromm at microchip.com
Christian.Gromm at microchip.com
Thu May 2 08:02:56 UTC 2019
On Mi, 2019-04-24 at 21:23 +0200, Eugeniu Rosca wrote:
> External E-Mail
>
>
> From: Suresh Udipi <sudipi at jp.adit-jv.com>
>
> It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
> commit [1] missed to fix the memory leak in mod_exit function.
>
> Do it now.
>
> [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
> [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
> ("staging: most: cdev: fix leak for chrdev_region")
>
> Signed-off-by: Suresh Udipi <sudipi at jp.adit-jv.com>
> Signed-off-by: Eugeniu Rosca <erosca at de.adit-jv.com>
Acked-by: Christian Gromm <christian.gromm at microchip.com>
> ---
> drivers/staging/most/cdev/cdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/cdev/cdev.c
> b/drivers/staging/most/cdev/cdev.c
> index f2b347cda8b7..d5f236889021 100644
> --- a/drivers/staging/most/cdev/cdev.c
> +++ b/drivers/staging/most/cdev/cdev.c
> @@ -549,7 +549,7 @@ static void __exit mod_exit(void)
> destroy_cdev(c);
> destroy_channel(c);
> }
> - unregister_chrdev_region(comp.devno, 1);
> + unregister_chrdev_region(comp.devno, CHRDEV_REGION_SIZE);
> ida_destroy(&comp.minor_id);
> class_destroy(comp.class);
> }
More information about the devel
mailing list