[PATCH v3] staging: ralink-gdma: Use u32 over uint32_t

Joe Perches joe at perches.com
Sat Mar 23 00:53:55 UTC 2019


On Fri, 2019-03-22 at 22:43 +0530, Bharath Vedartham wrote:
> This fixes the checkpatch.pl warning: "Prefer u32 over uint32_t"

Please run your proposed patches through checkpatch before
submitting them.

> Signed-off-by: Bharath Vedartham <linux.bhar at gmail.com>
> ---
> Changes since v2
> 	- Improved changelog
> 	- Thanks for the good feedback. I am a beginner. I will learn
> 	  and grow. :)

More feedback for you.

> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
[]
> @@ -157,14 +157,14 @@ static struct gdma_dma_desc *to_gdma_dma_desc(struct virt_dma_desc *vdesc)
>  	return container_of(vdesc, struct gdma_dma_desc, vdesc);
>  }
>  
> -static inline uint32_t gdma_dma_read(struct gdma_dma_dev *dma_dev,
> +static inline u32 gdma_dma_read(struct gdma_dma_dev *dma_dev,
>  				     unsigned int reg)

Please realign the line following your change.




More information about the devel mailing list