[PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c
Chuanhong Guo
gch981213 at gmail.com
Thu Mar 14 02:26:47 UTC 2019
Hi!
On Thu, Mar 14, 2019 at 6:14 AM NeilBrown <neil at brown.name> wrote:
>
> [...]
> My only small concern is that this driver was backported to openwrt
> (4.14 based) and then reverted
>
> https://github.com/openwrt/openwrt/commit/749a29f76ca780d8df70a5163d43bbdc6f13ba3f
>
> "This breaks some mt7621 devices."
>
> Possibly it was backported badly, or possibly there is a problem.
Last time I backported the version with broken SPI modes so it got
broken SPI CS1 support. There is one mt7621 router using SPI CS1 in
OpenWrt and the backported driver broke it.
It has been fixed by my two "drop broken spi modes" patches.
>
> John: do you have any more details of the problem other than what is in
> the commit message?
>
> Thanks,
> NeilBrown
Regards,
Chuanhong Guo
More information about the devel
mailing list