[PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

Colin Ian King colin.king at canonical.com
Mon Mar 11 14:10:12 UTC 2019


On 11/03/2019 14:07, Dan Carpenter wrote:
> On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote:
>> There is no need to have the 'T *v' variable static
>> since new value always be assigned before use it.
>>
>> Signed-off-by: Mao Wenan <maowenan at huawei.com>
>> ---
>>  drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> index 6098f43ac51b..a2a672d4615d 100644
>> --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
>> @@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
>>  	struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
>>  	struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
>>  	struct media_entity *me = &sd->entity;
>> -	static resource_size_t  res_len;
>> +	resource_size_t  res_len;
>                         ^
> Could you remove the extra space character also, please.

shouldn't checkpatch find these?

> 
>>  	struct resource *res;
>>  	int ret;
> 
> regards,
> dan carpenter
> 
> 



More information about the devel mailing list