[PATCH] staging: media: davinci_vpfe: prefer using BIT macro

Jeeeun Evans jeeeunevans at gmail.com
Tue Jun 25 10:51:13 UTC 2019


Use BIT(x) instead of (1<<x), reported by checkpatch.pl.

Signed-off-by: Jeeeun Evans <jeeeunevans at gmail.com>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.h     | 2 +-
 drivers/staging/media/davinci_vpfe/dm365_isif.h      | 4 ++--
 drivers/staging/media/davinci_vpfe/dm365_isif_regs.h | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.h b/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
index 866ae12aeb07..de9b04683d82 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
@@ -99,7 +99,7 @@ struct ipipe_module_params {
 #define IPIPE_PADS_NUM			2
 
 #define IPIPE_OUTPUT_NONE		0
-#define IPIPE_OUTPUT_RESIZER		(1 << 0)
+#define IPIPE_OUTPUT_RESIZER		BIT(0)
 
 enum ipipe_input_entity {
 	IPIPE_INPUT_NONE = 0,
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.h b/drivers/staging/media/davinci_vpfe/dm365_isif.h
index 0e1fe472fb2b..288a1211b387 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif.h
@@ -172,8 +172,8 @@ enum isif_input_entity {
 };
 
 #define ISIF_OUTPUT_NONE	(0)
-#define ISIF_OUTPUT_MEMORY	(1 << 0)
-#define ISIF_OUTPUT_IPIPEIF	(1 << 1)
+#define ISIF_OUTPUT_MEMORY	BIT(0)
+#define ISIF_OUTPUT_IPIPEIF	BIT(1)
 
 struct vpfe_isif_device {
 	struct v4l2_subdev		subdev;
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h b/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
index 6695680817b9..e64b75dc1e5a 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
@@ -284,8 +284,8 @@
 #define ISIF_LIN_ENTRY_MASK			0x3ff
 
 /* masks and shifts*/
-#define ISIF_SYNCEN_VDHDEN_MASK			(1 << 0)
-#define ISIF_SYNCEN_WEN_MASK			(1 << 1)
+#define ISIF_SYNCEN_VDHDEN_MASK			BIT(0)
+#define ISIF_SYNCEN_WEN_MASK			BIT(1)
 #define ISIF_SYNCEN_WEN_SHIFT			1
 
 #endif		/* _DAVINCI_VPFE_DM365_ISIF_REGS_H */
-- 
2.22.0



More information about the devel mailing list