[PATCH] staging: kpc2000: simplify error handling in kp2000_pcie_probe

Dan Carpenter dan.carpenter at oracle.com
Wed Jun 19 06:53:06 UTC 2019

On Wed, Jun 19, 2019 at 08:36:07AM +0200, Simon Sandström wrote:
> We can get rid of a few iounmaps in the middle of the function by
> re-ordering the error handling labels and adding two new labels.
> Signed-off-by: Simon Sandström <simon at nikanor.nu>
> ---
> This change has not been tested besides by compiling. It might be good
> took take an extra look to make sure that I got everything right.

You have the right instincts that when something looks really
complicated that's probably for a reason.  That attitude will serve you
well in the future!  But in this case it's staging code so the original
code is just strange.

Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>

> Also, this change was proposed by Dan Carpenter. Should I add anything
> in the commit message to show this?

There is a Suggested-by: tag for this, but don't resend because I don't
care and I've already reviewed this version so I don't want to review
the patch again.

dan carpenter

More information about the devel mailing list