[driver-core:debugfs_cleanup 151/155] drivers/gpio/gpio-mockup.c:336:4: error: label 'err' used but not defined

kbuild test robot lkp at intel.com
Tue Jun 18 20:00:14 UTC 2019


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head:   b1494ab6cdfdf79167ae2e9054d57e86a4130f5f
commit: 13e71424e523cd0da6095ac037ed2ecdf0424f68 [151/155] gpio: mockup: no need to check return value of debugfs_create functions
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 13e71424e523cd0da6095ac037ed2ecdf0424f68
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-mockup.c: In function 'gpio_mockup_debugfs_setup':
>> drivers/gpio/gpio-mockup.c:336:4: error: label 'err' used but not defined
       goto err;
       ^~~~
   drivers/gpio/gpio-mockup.c:318:17: warning: unused variable 'evfile' [-Wunused-variable]
     struct dentry *evfile;
                    ^~~~~~

vim +/err +336 drivers/gpio/gpio-mockup.c

9202ba23 Bartosz Golaszewski 2017-02-06  313  
9202ba23 Bartosz Golaszewski 2017-02-06  314  static void gpio_mockup_debugfs_setup(struct device *dev,
9202ba23 Bartosz Golaszewski 2017-02-06  315  				      struct gpio_mockup_chip *chip)
9202ba23 Bartosz Golaszewski 2017-02-06  316  {
9202ba23 Bartosz Golaszewski 2017-02-06  317  	struct gpio_mockup_dbgfs_private *priv;
d51ee07a Bartosz Golaszewski 2019-01-17  318  	struct dentry *evfile;
9202ba23 Bartosz Golaszewski 2017-02-06  319  	struct gpio_chip *gc;
ca8792af Bartosz Golaszewski 2017-11-27  320  	const char *devname;
9202ba23 Bartosz Golaszewski 2017-02-06  321  	char *name;
9202ba23 Bartosz Golaszewski 2017-02-06  322  	int i;
9202ba23 Bartosz Golaszewski 2017-02-06  323  
9202ba23 Bartosz Golaszewski 2017-02-06  324  	gc = &chip->gc;
ca8792af Bartosz Golaszewski 2017-11-27  325  	devname = dev_name(&gc->gpiodev->dev);
9202ba23 Bartosz Golaszewski 2017-02-06  326  
ca8792af Bartosz Golaszewski 2017-11-27  327  	chip->dbg_dir = debugfs_create_dir(devname, gpio_mockup_dbg_dir);
9202ba23 Bartosz Golaszewski 2017-02-06  328  
9202ba23 Bartosz Golaszewski 2017-02-06  329  	for (i = 0; i < gc->ngpio; i++) {
9202ba23 Bartosz Golaszewski 2017-02-06  330  		name = devm_kasprintf(dev, GFP_KERNEL, "%d", i);
9202ba23 Bartosz Golaszewski 2017-02-06  331  		if (!name)
9202ba23 Bartosz Golaszewski 2017-02-06  332  			goto err;
9202ba23 Bartosz Golaszewski 2017-02-06  333  
9202ba23 Bartosz Golaszewski 2017-02-06  334  		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
9202ba23 Bartosz Golaszewski 2017-02-06  335  		if (!priv)
9202ba23 Bartosz Golaszewski 2017-02-06 @336  			goto err;
9202ba23 Bartosz Golaszewski 2017-02-06  337  
9202ba23 Bartosz Golaszewski 2017-02-06  338  		priv->chip = chip;
9202ba23 Bartosz Golaszewski 2017-02-06  339  		priv->offset = i;
9202ba23 Bartosz Golaszewski 2017-02-06  340  		priv->desc = &gc->gpiodev->descs[i];
9202ba23 Bartosz Golaszewski 2017-02-06  341  
13e71424 Greg Kroah-Hartman  2019-06-18  342  		debugfs_create_file(name, 0200, chip->dbg_dir, priv,
2a9e2740 Bartosz Golaszewski 2019-01-17  343  				    &gpio_mockup_debugfs_ops);
9202ba23 Bartosz Golaszewski 2017-02-06  344  	}
9202ba23 Bartosz Golaszewski 2017-02-06  345  
9202ba23 Bartosz Golaszewski 2017-02-06  346  	return;
9202ba23 Bartosz Golaszewski 2017-02-06  347  }
9202ba23 Bartosz Golaszewski 2017-02-06  348  

:::::: The code at line 336 was first introduced by commit
:::::: 9202ba2397d1ded79078606c6921787b27a85e1a gpio: mockup: implement event injecting over debugfs

:::::: TO: Bartosz Golaszewski <bgolaszewski at baylibre.com>
:::::: CC: Linus Walleij <linus.walleij at linaro.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 58633 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20190619/94d06d33/attachment-0001.bin>


More information about the devel mailing list