[PATCH] staging: rtl8723bs: remove redundant assignment to rtStatus

Colin King colin.king at canonical.com
Mon Jun 17 12:47:26 UTC 2019


From: Colin Ian King <colin.king at canonical.com>

Variable rtStatus is initialized with a value that is never read
and later it is reassigned a new value.  Hence the initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 21f2365fa627..bda19769c37f 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -352,7 +352,7 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padapter)
 /*  */
 s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool  bUsedWoWLANFw)
 {
-	s32 rtStatus = _SUCCESS;
+	s32 rtStatus;
 	u8 write_fw = 0;
 	unsigned long fwdl_start_time;
 	struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
-- 
2.20.1



More information about the devel mailing list