[PATCH V4 05/16] scsi: ipr: use sg helper to operate scatterlist
Christoph Hellwig
hch at lst.de
Mon Jun 17 08:24:23 UTC 2019
> - for (i = 0; i < (len / bsize_elem); i++, buffer += bsize_elem) {
> - struct page *page = sg_page(&scatterlist[i]);
> + for (i = 0; i < (len / bsize_elem); i++, sg = sg_next(sg), buffer += bsize_elem) {
Please split the overly long line.
> + struct page *page = sg_page(sg);
>
> kaddr = kmap(page);
> memcpy(kaddr, buffer, bsize_elem);
> kunmap(page);
Not new in this patch, but this is buggy as scatterlists could have
offsets. This should probably use the scatterlist.c copy helper
eventually.
More information about the devel
mailing list