[PATCH 1/6] staging: kpc2000_dma: added Kconfig to enable asynchronous I/O.

Greg KH gregkh at linuxfoundation.org
Thu Jun 13 08:45:31 UTC 2019


On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote:
> The DMA driver has call-backs for doing asynchronous I/O which are
> protected by a CONFIG_ macro which is not defined.  Added a Kconfig
> stanza to define it.
> 
> Cc: Matt Sickler <matt.sickler at daktronics.com>
> Signed-off-by: Jeremy Sowden <jeremy at azazel.net>
> ---
>  drivers/staging/kpc2000/Kconfig           | 8 ++++++++
>  drivers/staging/kpc2000/kpc_dma/fileops.c | 6 +++---
>  2 files changed, 11 insertions(+), 3 deletions(-)

This patch breaks the build if you enable the new build option.  So it
probably should go _after_ you have fixed up the code.

Please fix this series up and resend it.
Also, is aio even wanted/needed for this driver?  If it's been disabled
for so long, can't we just delete it if no one is using it?

thanks,

greg k-h


More information about the devel mailing list