[PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

Dan Carpenter dan.carpenter at oracle.com
Thu Jun 13 08:35:06 UTC 2019

On Thu, Jun 13, 2019 at 01:53:20PM +0530, Nishka Dasgupta wrote:
> On 13/06/19 12:15 PM, Dan Carpenter wrote:
> > On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote:
> > > Remove unused function eeprom_read_sz.
> > > Issue found with Coccinelle.
> > > 
> > > Signed-off-by: Nishka Dasgupta <nishkadg.linux at gmail.com>
> > 
> > This is great but you need to remove the declaration from the .h file
> > as well.  I noticed some of the other patches have this problem as well
> > so please check them and resend the whole set.
> I'm sorry, I couldn't find the declaration in any .h file for any of these
> patches, even after fetch origin, rebase, and grep. Going to individual .h
> files and searching for declarations does not seem to work either. Is there
> any other way I can look for the declarations?

Oh...  Heh.  Sorry for the noise.  My bad.

I was looking at the wrong driver.  It's declared but not implemented in
rtl8188eu in drivers/staging/rtl8188eu/include/rtw_eeprom.h.  We should
delete those too, but it's unrelated to your patchset so don't worry
about it.

dan carpenter

More information about the devel mailing list