[PATCH] staging: rtl8723bs: core: rtw_mlme_ext.c: Remove unused variables

Nishka Dasgupta nishkadg.linux at gmail.com
Mon Jun 10 07:14:05 UTC 2019


On 10/06/19 11:19 AM, Greg KH wrote:
> On Mon, Jun 10, 2019 at 10:08:21AM +0530, Nishka Dasgupta wrote:
>> On 09/06/19 4:32 PM, Greg KH wrote:
>>> On Fri, Jun 07, 2019 at 12:41:23PM +0530, Nishka Dasgupta wrote:
>>>> Remove variables that are declared and assigned values but not otherwise
>>>> used.
>>>> Issue found with Coccinelle.
>>>>
>>>> Signed-off-by: Nishka Dasgupta <nishkadg.linux at gmail.com>
>>>> ---
>>>>    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 ---------
>>>>    1 file changed, 9 deletions(-)
>>>
>>> You sent me 8 patches for this driver, yet only 2 were ordered in a
>>> series.  I have no idea what order to apply these in :(
>>>
>>> Please resend them _all_ in a numbered patch series so I have a chance
>>> to get this correct.
>>
>> Yes, I can do that. Who do I send the patch series to in that case? The
>> maintainers list is slightly different for each file, and most of the
>> patches in this driver are for different and unrelated files (except, I
>> think, the two that I did send as a patch series). Do I combine the
>> maintainers lists and send the entire patch series to everyone listed as a
>> maintainer for any one of the patches in it?
> 
> The maintainer and mailing list is the same for all of the files in a
> single driver.  If not, then something is wrong.

I'm using get_maintainers.pl with no arguments, and for rtl8723bs, I am 
getting a lot of different mailing lists.
E.g
For core/rtw_ieee80211.c, I'm getting the following list:
Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Michael Straube <straube.linux at gmail.com>
Andy Shevchenko <andy.shevchenko at gmail.com>
Hardik Singh Rathore <hardiksingh.k at gmail.com>
Payal Kshirsagar <payal.s.kshirsagar.98 at gmail.com>
Nishka Dasgupta <nishkadg.linux at gmail.com>
devel at driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-kernel at vger.kernel.org (open list)

Which is not the same as for core/rtw_mlme_ext.c (the current patch).

> And yes, you can combine the list of people if you wish but be sure you
> are not just randomly including people who happened to touch the driver
> "last".

Okay, I'll combine then. But is there any metric I should be using to 
filter the output of get_maintainer.pl? Currently I'm running it with no 
arguments and just adding everyone.

Thanking you,
Nishka

> greg k-h
> 



More information about the devel mailing list