[PATCH v2 1/2] staging: kpc2000: Use '%llx' for printing 'long long int' type

Fabio Estevam festevam at gmail.com
Wed Jun 5 21:54:21 UTC 2019


In order to print a 'long long int' type the 'llx' specifier needs to be
used.

Change it accordingly in order to fix the following build warning:

drivers/staging/kpc2000/kpc2000/core.c:245:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'long long int' [-Wformat=]

Reported-by: Build bot for Mark Brown <broonie at kernel.org>
Signed-off-by: Fabio Estevam <festevam at gmail.com>
---
Changes since v1:
- Mark KP2000_MAGIC_VALUE to avoid build warnings in ARM32

 drivers/staging/kpc2000/kpc2000/core.c | 2 +-
 drivers/staging/kpc2000/kpc2000/pcie.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c
index 7f257c21e0cc..65eaa8451928 100644
--- a/drivers/staging/kpc2000/kpc2000/core.c
+++ b/drivers/staging/kpc2000/kpc2000/core.c
@@ -242,7 +242,7 @@ static int  read_system_regs(struct kp2000_device *pcard)
 	read_val = readq(pcard->sysinfo_regs_base + REG_MAGIC_NUMBER);
 	if (read_val != KP2000_MAGIC_VALUE) {
 		dev_err(&pcard->pdev->dev,
-			"Invalid magic!  Got: 0x%016llx  Want: 0x%016lx\n",
+			"Invalid magic!  Got: 0x%016llx  Want: 0x%016llx\n",
 			read_val, KP2000_MAGIC_VALUE);
 		return -EILSEQ;
 	}
diff --git a/drivers/staging/kpc2000/kpc2000/pcie.h b/drivers/staging/kpc2000/kpc2000/pcie.h
index d3cdb515a75c..cb815c30faa4 100644
--- a/drivers/staging/kpc2000/kpc2000/pcie.h
+++ b/drivers/staging/kpc2000/kpc2000/pcie.h
@@ -39,7 +39,7 @@
 #define REG_INTERRUPT_ACTIVE		(9 * REG_WIDTH)
 #define REG_PCIE_ERROR_COUNT		(10 * REG_WIDTH)
 
-#define KP2000_MAGIC_VALUE		0x196C61482231894D
+#define KP2000_MAGIC_VALUE		0x196C61482231894DULL
 
 #define PCI_VENDOR_ID_DAKTRONICS	0x1c33
 #define PCI_DEVICE_ID_DAKTRONICS	0x6021
-- 
2.17.1



More information about the devel mailing list