[PATCH 1/2] staging: kpc2000: Use '%llx' for printing 'long long int' type

Fabio Estevam festevam at gmail.com
Wed Jun 5 21:44:20 UTC 2019


Hi Greg,

On Wed, Jun 5, 2019 at 6:37 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> In order to print a 'long long int' type the 'llx' specifier needs to be
> used.
>
> Change it accordingly in order to fix the following build warning:
>
> drivers/staging/kpc2000/kpc2000/core.c:245:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'long long int' [-Wformat=]
>
> Reported-by: Build bot for Mark Brown <broonie at kernel.org>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
>  drivers/staging/kpc2000/kpc2000/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c
> index 7f257c21e0cc..65eaa8451928 100644
> --- a/drivers/staging/kpc2000/kpc2000/core.c
> +++ b/drivers/staging/kpc2000/kpc2000/core.c
> @@ -242,7 +242,7 @@ static int  read_system_regs(struct kp2000_device *pcard)
>         read_val = readq(pcard->sysinfo_regs_base + REG_MAGIC_NUMBER);
>         if (read_val != KP2000_MAGIC_VALUE) {
>                 dev_err(&pcard->pdev->dev,
> -                       "Invalid magic!  Got: 0x%016llx  Want: 0x%016lx\n",
> +                       "Invalid magic!  Got: 0x%016llx  Want: 0x%016llx\n",

Please discard this. It fixes arm32 build warning, but introduces
warnings with arm64.

I will think about a better fix.


More information about the devel mailing list