[PATCH] staging: kpc2000: kpc_dma: fix symbol 'kpc_dma_add_device' was not declared.

Greg KH gregkh at linuxfoundation.org
Wed Jun 5 16:11:09 UTC 2019


On Wed, Jun 05, 2019 at 05:57:11PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:39:7: warning: symbol 'kpc_dma_add_device
> ' was not declared. Should it be static?
> 
> Signed-off-by: Valerio Genovese <valerio.click at gmail.com>
> ---
>  drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h
> index ee47f43e71cf..19e88c3bc13f 100644
> --- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h
> +++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h
> @@ -56,6 +56,7 @@ struct dev_private_data {
>  };
>  
>  struct kpc_dma_device *kpc_dma_lookup_device(int minor);
> +void kpc_dma_add_device(struct kpc_dma_device *ldev);
>  
>  extern const struct file_operations  kpc_dma_fops;
>  

This is not how you fix this issue.

Look at the warning given to you.  Think about your C programming
knowledge and remember what the 'static' keyword is and does.

Then fix the issue properly.

thanks,

greg k-h


More information about the devel mailing list