[PATCH 1/2] staging: rtl8188eu: remove redundant definition of ETH_ALEN

Michael Straube straube.linux at gmail.com
Mon Jun 3 06:10:26 UTC 2019


On 2019-06-02 22:07, Joe Perches wrote:
> On Sun, 2019-06-02 at 18:35 +0200, Michael Straube wrote:
>> ETH_ALEN is defined in linux/if_ether.h which is included by
>> osdep_service.h, so remove the redundant definition from ieee80211.h.
> []
>> diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b/drivers/staging/rtl8188eu/include/ieee80211.h
> []
>> @@ -14,7 +14,6 @@
>>   
>>   #define MGMT_QUEUE_NUM 5
>>   
>> -#define ETH_ALEN	6
>>   #define ETH_TYPE_LEN		2
>>   #define PAYLOAD_TYPE_LEN	1
> 
> While you're at it:
> 
> neither ETH_TYPE_LEN nor PAYLOAD_TYPE_LEN appear to be used.
> 
> 

They are removed in the second patch of the series.


More information about the devel mailing list