[driver-core:debugfs_cleanup 22/55] sound//soc/soc-core.c:231:2: note: in expansion of macro 'if'

kbuild test robot lkp at intel.com
Wed Jul 17 14:39:44 UTC 2019


tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head:   e1b58c1031e00b7530c136d770b15fff28fe127e
commit: 404c2a99031c0ce08425dbec2e556c6a02861bbd [22/55] sound: soc: core: no need to check return value of debugfs_create functions
config: x86_64-randconfig-c001-201928 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        git checkout 404c2a99031c0ce08425dbec2e556c6a02861bbd
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   sound//soc/soc-core.c: In function 'soc_init_card_debugfs':
   sound//soc/soc-core.c:228:8: error: 'struct snd_soc_card' has no member named 'debugfs_pop_time'; did you mean 'debugfs_card_root'?
     card->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
           ^~~~~~~~~~~~~~~~
           debugfs_card_root
   In file included from include/linux/export.h:45:0,
                    from include/linux/linkage.h:7,
                    from include/linux/kernel.h:8,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from sound//soc/soc-core.c:20:
   sound//soc/soc-core.c:231:19: error: 'struct snd_soc_card' has no member named 'debugfs_pop_time'; did you mean 'debugfs_card_root'?
     if (IS_ERR(card->debugfs_pop_time))
                      ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> sound//soc/soc-core.c:231:2: note: in expansion of macro 'if'
     if (IS_ERR(card->debugfs_pop_time))
     ^~
   sound//soc/soc-core.c:231:19: error: 'struct snd_soc_card' has no member named 'debugfs_pop_time'; did you mean 'debugfs_card_root'?
     if (IS_ERR(card->debugfs_pop_time))
                      ^
   include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                                ^~~~
>> sound//soc/soc-core.c:231:2: note: in expansion of macro 'if'
     if (IS_ERR(card->debugfs_pop_time))
     ^~
   sound//soc/soc-core.c:231:19: error: 'struct snd_soc_card' has no member named 'debugfs_pop_time'; did you mean 'debugfs_card_root'?
     if (IS_ERR(card->debugfs_pop_time))
                      ^
   include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
     (cond) ?     \
      ^~~~
   include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                               ^~~~~~~~~~~~~~
>> sound//soc/soc-core.c:231:2: note: in expansion of macro 'if'
     if (IS_ERR(card->debugfs_pop_time))
     ^~
   In file included from include/linux/platform_device.h:13:0,
                    from sound//soc/soc-core.c:27:
   sound//soc/soc-core.c:234:19: error: 'struct snd_soc_card' has no member named 'debugfs_pop_time'; did you mean 'debugfs_card_root'?
        PTR_ERR(card->debugfs_pop_time));
                      ^
   include/linux/device.h:1495:33: note: in definition of macro 'dev_warn'
     _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                    ^~~~~~~~~~~

vim +/if +231 sound//soc/soc-core.c

db795f9b Kuninori Morimoto 2018-05-08  215  
a6052154 Jarkko Nikula     2010-11-05  216  static void soc_init_card_debugfs(struct snd_soc_card *card)
a6052154 Jarkko Nikula     2010-11-05  217  {
a6052154 Jarkko Nikula     2010-11-05  218  	card->debugfs_card_root = debugfs_create_dir(card->name,
8a9dab1a Mark Brown        2011-01-10  219  						     snd_soc_debugfs_root);
c2c928c9 Mark Brown        2019-06-21  220  	if (IS_ERR(card->debugfs_card_root)) {
a6052154 Jarkko Nikula     2010-11-05  221  		dev_warn(card->dev,
c2c928c9 Mark Brown        2019-06-21  222  			 "ASoC: Failed to create card debugfs directory: %ld\n",
c2c928c9 Mark Brown        2019-06-21  223  			 PTR_ERR(card->debugfs_card_root));
c2c928c9 Mark Brown        2019-06-21  224  		card->debugfs_card_root = NULL;
3a45b867 Jarkko Nikula     2010-11-05  225  		return;
3a45b867 Jarkko Nikula     2010-11-05  226  	}
3a45b867 Jarkko Nikula     2010-11-05  227  
3a45b867 Jarkko Nikula     2010-11-05  228  	card->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
3a45b867 Jarkko Nikula     2010-11-05  229  						    card->debugfs_card_root,
3a45b867 Jarkko Nikula     2010-11-05  230  						    &card->pop_time);
c2c928c9 Mark Brown        2019-06-21 @231  	if (IS_ERR(card->debugfs_pop_time))
3a45b867 Jarkko Nikula     2010-11-05  232  		dev_warn(card->dev,
c2c928c9 Mark Brown        2019-06-21  233  			 "ASoC: Failed to create pop time debugfs file: %ld\n",
c2c928c9 Mark Brown        2019-06-21  234  			 PTR_ERR(card->debugfs_pop_time));
a6052154 Jarkko Nikula     2010-11-05  235  }
a6052154 Jarkko Nikula     2010-11-05  236  

:::::: The code at line 231 was first introduced by commit
:::::: c2c928c93173f220955030e8440517b87ec7df92 ASoC: core: Adapt for debugfs API change

:::::: TO: Mark Brown <broonie at kernel.org>
:::::: CC: Mark Brown <broonie at kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 37670 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20190717/bcba076b/attachment-0001.bin>


More information about the devel mailing list