[PATCH 0/4] staging: mt7621-pci: Handle minor issues

[Sergio Paracuellos]

Hi Brett,

On Fri, Jul 5, 2019 at 8:44 PM Brett Neumeier <bneumeier at gmail.com> wrote:
>
> On Wed, Jun 26, 2019 at 7:45 AM Sergio Paracuellos
> <sergio.paracuellos at gmail.com> wrote:
> > No problem, I also miss them rewritting code. That is bad :((.
> > > BTW, I applied that on top of your other recent fixes (that ones
> > > you pushed to  gregkh for staging). So I tested with the
> > > updated GPIO reset code.
> > Ok, anyway.. I have just sent the change jus to have the same code behaviour
> > that was being there before.
>
> FWIW, I have the same results as Greg -- the 4.2 driver works every
> time, staging-next frequently hangs.

I see, thanks for letting me know. We have to figure out what is wrong
and why we don't get an stable pci link.

>
> Out of curiosity, if it's not too complex an answer to go into, what's
> the benefit of the staging-next driver? Is there a reason to prefer it
> to the 4.2 driver?

In terms of stability, the driver which is in staging-next now is not
always working as expected,
so I really apologize for that because main changes have been done by
myself. In the other hand,
you have to think what is staging tree for. Staging contains drivers
that are not ready to be properly
mainlined into the "real" tree because they are not clean enough, the
use old apis and so on. The idea
of staging is to have a temporal place to properly clean drivers in
order to get them properly added into
the official mainline tree and directories. Doing that it will always
be supported in the kernel and it won't be
deleted for the tree. The mt7621 pci driver is now clean enough to
give it a try to be mainlined but we have to
achieve the problem of pci link stability that sometimes gets the
driver to hang.

Again, sorry for the inconvenience and any debug traces searching for
the problem, ideas or patches repairing the current problem are very
welcome.
I don't have hardware to test my changes on, so it is a bit difficult
for me to help more in these days.

Hope this helps.

Best regards,
    Sergio Paracuellos
>
> --
> Brett Neumeier (bneumeier at gmail.com)