[PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

Greg KH gregkh at linuxfoundation.org
Wed Jul 3 09:10:34 UTC 2019


On Wed, Jul 03, 2019 at 02:14:21PM +0530, Nishka Dasgupta wrote:
> On 03/07/19 2:07 PM, Greg KH wrote:
> > On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote:
> > > Remove file ion_carveout_heap.c as its functions and definitions are not
> > > used anywhere.
> > > Issue found with Coccinelle.
> > > 
> > > Signed-off-by: Nishka Dasgupta <nishkadg.linux at gmail.com>
> > > ---
> > >   drivers/staging/android/ion/Kconfig           |   9 --
> > >   drivers/staging/android/ion/Makefile          |   1 -
> > >   .../staging/android/ion/ion_carveout_heap.c   | 133 ------------------
> > 
> > I keep trying to do this, but others point out that the ion code is
> > "going to be fixed up soon" and that people rely on this interface now.
> > Well, "code outside of the kernel tree" relies on this, which is not ok,
> > but the "soon" people keep insisting on it...
> > 
> > Odds are I should just delete all of ION, as there hasn't been any
> > forward progress on it in a long time.
> 
> I'm sorry, I don't think I understand. Should I drop these patches from my
> tree then?

What "tree"?  Let's see what the ION maintainer and developers say
before rushing to anything.

thanks,

greg k-h


More information about the devel mailing list