[PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver
Rui Miguel Silva
rui.silva at linaro.org
Fri Jan 18 18:28:41 UTC 2019
Oi Fabio,
On Fri 18 Jan 2019 at 16:49, Fabio Estevam wrote:
> Hi Rui,
>
> On Fri, Dec 7, 2018 at 10:44 AM Hans Verkuil
> <hverkuil at xs4all.nl> wrote:
>
>> I got a few checkpatch warnings about coding style:
>>
>> CHECK: Alignment should match open parenthesis
>> #953: FILE: drivers/staging/media/imx/imx7-media-csi.c:911:
>> +static struct v4l2_mbus_framefmt *imx7_csi_get_format(struct
>> imx7_csi *csi,
>> + struct
>> v4l2_subdev_pad_config *cfg,
>>
>> CHECK: Alignment should match open parenthesis
>> #1341: FILE: drivers/staging/media/imx/imx7-media-csi.c:1299:
>> + ret = v4l2_async_register_fwnode_subdev(&csi->sd,
>> + sizeof(struct
>> v4l2_async_subdev),
>>
>> CHECK: Lines should not end with a '('
>> #684: FILE: drivers/staging/media/imx/imx7-mipi-csis.c:669:
>> +static struct csis_pix_format const *mipi_csis_try_format(
>>
>> CHECK: Alignment should match open parenthesis
>> #708: FILE: drivers/staging/media/imx/imx7-mipi-csis.c:693:
>> +static struct v4l2_mbus_framefmt *mipi_csis_get_format(struct
>> csi_state *state,
>> + struct
>> v4l2_subdev_pad_config *cfg,
>>
>> CHECK: Alignment should match open parenthesis
>> #936: FILE: drivers/staging/media/imx/imx7-mipi-csis.c:921:
>> + ret = v4l2_async_register_fwnode_subdev(mipi_sd,
>> + sizeof(struct
>> v4l2_async_subdev), &sink_port, 1,
>>
>> Apparently the latest coding style is that alignment is more
>> important than
>> line length, although I personally do not agree. But since you
>> need to
>> respin in any case due to the wrong SPDX identifier you used
>> you might as
>> well take this into account.
>>
>> I was really hoping I could merge this, but the SPDX license
>> issue killed it.
>
> Do you plan to submit a new version?
Yeah, I will try to send one next week. I think have all this
addressed in a branch, I will need to rebase again.
---
Cheers,
Rui
More information about the devel
mailing list