[PATCH v4 1/4] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

Nishad Kamdar nishadkamdar at gmail.com
Thu Jan 10 17:38:12 UTC 2019


On Wed, Jan 09, 2019 at 11:44:14AM +0100, Johan Hovold wrote:
> On Sat, Dec 22, 2018 at 08:17:02PM +0530, Nishad Kamdar wrote:
> > Convert the GPIO driver to use the GPIO irqchip library
> > GPIOLIB_IRQCHIP instead of reimplementing the same.
> > 
> > Signed-off-by: Nishad Kamdar <nishadkamdar at gmail.com>
> > ---
> > Changes in v4:
> >  - Remove changes related to conversion to gpiochip_get_data() to
> >    include it as a new patch.
> >  - Remove the 'struct irq_chip' field from 'struct gb_gpio_controller'
> >    as struct gpio_chip will have an irqchip whenever
> >    CONFIG_GPIOLIB_IRQCHIP is selected.
> 
> Ok, sorry for misleading you this. It seems we cannot use the gpio-chip
> irqchip, since that will register the irqchip automatically and possibly
> in an incompatible way. This new functionality is far from well
> documented, and you basically have to review the gpiolib code to figure
> it out.
> 
Ok, I get it.
> Looks like you need to add back the struct irq_chip.
> 
Ok, I'll do that.
> Johan

Thanks for the review.

Regards,
Nishad


More information about the devel mailing list