[PATCH] Mediatek staging: Use individual config flags in Makefile

Greg KH greg at kroah.com
Thu Jan 10 07:39:47 UTC 2019


On Thu, Jan 10, 2019 at 12:26:28AM -0700, thirtythreeforty at gmail.com wrote:
> From: George Hilliard <thirtythreeforty at gmail.com>
> 
> These drivers are useful on other MT76xx SoCs, which have compatible
> peripherals.  The drivers are selectable in Kconfig, but they were
> quietly excluded from the build because the SOC_MT7621 chip was not
> selected.  So, make the main staging Makefile use the same flags as
> everything else for these drivers.
> 
> I have personally confirmed that the mt7621-spi driver works on the
> MT7688, which was what prompted this change.
> 
> Cc: devel at driverdev.osuosl.org
> Cc: Matthias Brugger <matthias.bgg at gmail.com>
> Cc: John Crispin <blogic at openwrt.org>
> Signed-off-by: George Hilliard <thirtythreeforty at gmail.com>
> ---
>  drivers/staging/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index 5868631e8f1b..50c980c16c0d 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -42,10 +42,10 @@ obj-$(CONFIG_BCM2835_VCHIQ)	+= vc04_services/
>  obj-$(CONFIG_DRM_VBOXVIDEO)	+= vboxvideo/
>  obj-$(CONFIG_PI433)		+= pi433/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-pci/
> -obj-$(CONFIG_SOC_MT7621)	+= mt7621-pinctrl/
> -obj-$(CONFIG_SOC_MT7621)	+= mt7621-spi/
> +obj-$(CONFIG_PINCTRL_RT2880)	+= mt7621-pinctrl/
> +obj-$(CONFIG_SPI_MT7621)	+= mt7621-spi/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-dma/

What about the DMA driver?

> -obj-$(CONFIG_SOC_MT7621)	+= mt7621-mmc/
> +obj-$(CONFIG_MTK_MMC)	+= mt7621-mmc/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-eth/
>  obj-$(CONFIG_SOC_MT7621)	+= mt7621-dts/

And these drivers?  Why not change all of these at once?

thanks,

greg k-h


More information about the devel mailing list