[PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

Nick Desaulniers ndesaulniers at google.com
Thu Jan 10 00:19:30 UTC 2019


Digging up an old thread to point out I was wrong:

On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers
<ndesaulniers at google.com> wrote:
> > This is not a million-little-commits problem; more like 2 drivers in
> > the whole tree have this problem.
> >
> > Note that this change that Nathan has DOES NOT need to applied to
> > every driver that uses MODULE_DEVICE_TABLE.  Only when the struct has
> > no other references other than JUST being passed to
> > MODULE_DEVICE_TABLE() is this a problem.  For an allyesconfig, I only
> > see 2 instances of this case in the whole tree:
> >
> > https://github.com/ClangBuiltLinux/linux/issues/169 <- this patch is addressing
> > https://github.com/ClangBuiltLinux/linux/issues/178 <- waiting on the
> > results of this patch
> >
> > If you're ok with this change to two drivers, then:
> > Reviewed-by: Nick Desaulniers <ndesaulniers at google.com>

I just landed a fix for this in Clang
(https://reviews.llvm.org/rL350776) which will ship soon in Clang 8.
Sedat helped test this patch and reported that it removed 41
false-negative warnings
https://github.com/ClangBuiltLinux/linux/issues/232#issuecomment-440006399
-- 
Thanks,
~Nick Desaulniers


More information about the devel mailing list