[PATCH 3/3] staging: rtl8192e: rename members of struct rtllib_device - style

Himadri Pandya himadri18.07 at gmail.com
Tue Feb 5 20:14:55 UTC 2019


On 05/02/19 11:52 PM, Greg KH wrote:
> On Tue, Feb 05, 2019 at 07:22:11PM +0100, Greg KH wrote:
>> On Tue, Feb 05, 2019 at 09:42:39AM -0800, Himadri Pandya wrote:
>>> Rename following members of struct rtllib_device to fix checkpatch
>>> warning: Avoid CamelCase
>>>
>>> 	pDot11dInfo -> dot11d_info
>>>          bGlobalDomain -> global_domain
>>>          IbssStartChnl -> ibss_start_chnl
>> Why the use of tabs on the first line and not on the others?
>>
>> Anyway, same comment here, "ibss_start_channel"?
> Oops, no, it should be "bss_start_channel", no need for the initial "i",
> that was left over from the horrid notation style.

Noted. Renaming it to "bss_start_channel" in V2. Thank you.

- Himadri



More information about the devel mailing list