[PATCH 1/6] staging: rtl8192e: rename structure members to avoid camel case - style

Greg KH gregkh at linuxfoundation.org
Mon Feb 4 15:41:16 UTC 2019


On Mon, Feb 04, 2019 at 04:25:43AM -0800, Himadri Pandya wrote:
>  struct rt_dot11d_info {
> -	bool bEnabled;
> +	bool b_enabled;

Please think about _what_ you are renaming.  Does your new name make any
sense?  Why was the "b" there in the first place?  Why keep it?

These are not to be just mindless changes, you have to pick a good name
for the new variable.  What you did here isn't a good name, you just
turned caps into _, while a scriptable thing to do, not good for the
goal of how to name things well.

Also, you dod a lot of different fields and structures all at once.  At
the most, do this one structure at a time.

thanks,

greg k-h


More information about the devel mailing list