[driver-core:debugfs_remove_return_value 2/2] drivers/crypto/hisilicon/hpre/hpre_main.c:598:6: error: void value not ignored as it ought to be

kbuild test robot lkp at intel.com
Thu Dec 12 23:03:11 UTC 2019


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_remove_return_value
head:   ccebb9244d66f0fe7d7fd6a6fe45d0d5a812bd60
commit: ccebb9244d66f0fe7d7fd6a6fe45d0d5a812bd60 [2/2] debugfs: remove return value of debugfs_create_regset32()
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-1) 7.5.0
reproduce:
        git checkout ccebb9244d66f0fe7d7fd6a6fe45d0d5a812bd60
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   drivers/crypto/hisilicon/hpre/hpre_main.c: In function 'hpre_pf_comm_regs_debugfs_init':
>> drivers/crypto/hisilicon/hpre/hpre_main.c:598:6: error: void value not ignored as it ought to be
     tmp = debugfs_create_regset32("regs", 0444,  debug->debug_root, regset);
         ^
   drivers/crypto/hisilicon/hpre/hpre_main.c: In function 'hpre_cluster_debugfs_init':
   drivers/crypto/hisilicon/hpre/hpre_main.c:630:7: error: void value not ignored as it ought to be
      tmp = debugfs_create_regset32("regs", 0444, tmp_d, regset);
          ^

sparse warnings: (new ones prefixed by >>)

>> drivers/crypto/hisilicon/hpre/hpre_main.c:598:13: sparse: sparse: incorrect type in assignment (different base types)
   drivers/crypto/hisilicon/hpre/hpre_main.c:598:13: sparse:    expected struct dentry *tmp
   drivers/crypto/hisilicon/hpre/hpre_main.c:598:13: sparse:    got void
   drivers/crypto/hisilicon/hpre/hpre_main.c:630:21: sparse: sparse: incorrect type in assignment (different base types)
   drivers/crypto/hisilicon/hpre/hpre_main.c:630:21: sparse:    expected struct dentry *tmp
   drivers/crypto/hisilicon/hpre/hpre_main.c:630:21: sparse:    got void

vim +598 drivers/crypto/hisilicon/hpre/hpre_main.c

8489741516182d Zaibo Xu 2019-09-30  581  
8489741516182d Zaibo Xu 2019-09-30  582  static int hpre_pf_comm_regs_debugfs_init(struct hpre_debug *debug)
8489741516182d Zaibo Xu 2019-09-30  583  {
8489741516182d Zaibo Xu 2019-09-30  584  	struct hpre *hpre = container_of(debug, struct hpre, debug);
8489741516182d Zaibo Xu 2019-09-30  585  	struct hisi_qm *qm = &hpre->qm;
8489741516182d Zaibo Xu 2019-09-30  586  	struct device *dev = &qm->pdev->dev;
8489741516182d Zaibo Xu 2019-09-30  587  	struct debugfs_regset32 *regset;
8489741516182d Zaibo Xu 2019-09-30  588  	struct dentry *tmp;
8489741516182d Zaibo Xu 2019-09-30  589  
8489741516182d Zaibo Xu 2019-09-30  590  	regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL);
8489741516182d Zaibo Xu 2019-09-30  591  	if (!regset)
8489741516182d Zaibo Xu 2019-09-30  592  		return -ENOMEM;
8489741516182d Zaibo Xu 2019-09-30  593  
8489741516182d Zaibo Xu 2019-09-30  594  	regset->regs = hpre_com_dfx_regs;
8489741516182d Zaibo Xu 2019-09-30  595  	regset->nregs = ARRAY_SIZE(hpre_com_dfx_regs);
8489741516182d Zaibo Xu 2019-09-30  596  	regset->base = qm->io_base;
8489741516182d Zaibo Xu 2019-09-30  597  
8489741516182d Zaibo Xu 2019-09-30 @598  	tmp = debugfs_create_regset32("regs", 0444,  debug->debug_root, regset);
8489741516182d Zaibo Xu 2019-09-30  599  	if (!tmp)
8489741516182d Zaibo Xu 2019-09-30  600  		return -ENOENT;
8489741516182d Zaibo Xu 2019-09-30  601  
8489741516182d Zaibo Xu 2019-09-30  602  	return 0;
8489741516182d Zaibo Xu 2019-09-30  603  }
8489741516182d Zaibo Xu 2019-09-30  604  

:::::: The code at line 598 was first introduced by commit
:::::: 8489741516182d8ac57a69e9f4ca963450607351 crypto: hisilicon - Add debugfs for HPRE

:::::: TO: Zaibo Xu <xuzaibo at huawei.com>
:::::: CC: Herbert Xu <herbert at gondor.apana.org.au>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 71144 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20191213/eadb6723/attachment-0001.bin>


More information about the devel mailing list