[PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement
David Miller
davem at davemloft.net
Thu Dec 12 19:25:03 UTC 2019
From: Scott Schafer <schaferjscott at gmail.com>
Date: Thu, 12 Dec 2019 09:02:00 -0600
> On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
>> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
>> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp)
>> > mbcp->out_count = 6;
>> >
>> > status = ql_get_mb_sts(qdev, mbcp);
>> > - if (status)
>> > + if (status) {
>> > netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n");
>> > + }
>> > else {
>>
>> The close } should be on the same line as the else.
>>
>> > int i;
>> >
>>
>> regards,
>> dan carpenter
>
> this was fixed in patch 22
It should not be introduced in the first place. Therefore it needs to be dealt with
in this patch.
More information about the devel
mailing list