[PATCH RFC 2/6] staging: most: rename core.h to most.h

Christian.Gromm at microchip.com Christian.Gromm at microchip.com
Mon Dec 9 13:25:17 UTC 2019


On Fr, 2019-12-06 at 15:35 +0100, Greg KH wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Mon, Nov 25, 2019 at 04:51:32PM +0100, Christian Gromm wrote:
> > 
> > This patch renames the core header file core.h to most.h. The
> > intention
> > behind this is to have a meaningful name once this file is moved to
> > the
> > /include/linux directory.
> Does everything in this .h file have to be exposed to the whole
> kernel?
> Are there any things in here that are local only to the most "core"
> code?
> 
> If this whole thing is public, you might want to clean up your naming
> of
> some structures:

Yes, those structs are needed by modules registering with the core.

Do you want me to reroll v2 of this set with these changes or to wait
for more comments to come?

thanks,
Chris

> 
> > 
> > +enum mbo_status_flags {
> enum most_buffer_status_flags?
> 
> 
> > 
> > +struct mbo {
> struct most_buffer_object?
> 
> > 
> > +struct core_component {
> struct most_core_component?
> 
> thanks,
> 
> greg k-h


More information about the devel mailing list