[PATCH 1/2] pi433: Fix indentation according to coding style

Dan Carpenter dan.carpenter at oracle.com
Tue Dec 3 18:06:30 UTC 2019


On Tue, Dec 03, 2019 at 06:54:47PM +0100, Sven Leykauf wrote:
> Fix indentation so that no line exceeds the 80 character border.
> 
> Co-developed-by: Daniel Bauer <daniel.j.bauer at fau.de>
> Signed-off-by: Daniel Bauer <daniel.j.bauer at fau.de>
> Signed-off-by: Sven Leykauf <sven_leykauf1 at web.de>
> ---
>  drivers/staging/pi433/rf69.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 7d86bb8be245..6b13f92028c7 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -176,20 +176,20 @@ int rf69_set_modulation_shaping(struct spi_device *spi,
>  		switch (mod_shaping) {
>  		case SHAPING_OFF:
>  			return rf69_read_mod_write(spi, REG_DATAMODUL,
> -						   MASK_DATAMODUL_MODULATION_SHAPE,
> -						   DATAMODUL_MODULATION_SHAPE_NONE);
> +					MASK_DATAMODUL_MODULATION_SHAPE,
> +					DATAMODUL_MODULATION_SHAPE_NONE);

It was a choice to align with the ( or be less than 80 characters and
the original author decided to go over 80 characters...  They're both
equally valid options, but we generally let the original author choose
pick which one they prefer.  So just leave it as is.

There are better ways to write this function which avoid both problems...

regards,
dan carpenter



More information about the devel mailing list