rtl8192u - meaning of TO_DO_LIST?

stephen at brennan.io stephen at brennan.io
Thu Aug 22 21:51:46 UTC 2019


Hi all,

Similar to Colin's question yesterday about the rtl8192u driver, is
anybody familiar with the TO_DO_LIST define? As I looked through
checkpatch warnings I saw a particular concerning pattern in
drivers/staging/rtl8192u/r8192U.h:2183:

#ifdef TO_DO_LIST
	if (Adapter->bInHctTest)
		/* long statement here */
	else
#endif
	/* unindented statement here */

It seems this code would break if TO_DO_LIST were defined, and I verified
that it is the case. I can't find any comment or documentation about what
the goal of this "to do" item is.

Does anybody know what this is there for? If not, does it make sense to
just go ahead and remove the code there?

Stephen



More information about the devel mailing list