[PATCH] staging: rts5208: remove redundant assignment to retval

Colin King colin.king at canonical.com
Sun Aug 18 18:46:49 UTC 2019

From: Colin Ian King <colin.king at canonical.com>

Variable retval is initialized to a value that is never read and it
is re-assigned later. The initialization is redundant and can be

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king at canonical.com>
 drivers/staging/rts5208/ms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 1128eec3bd08..e853fa9cc950 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3842,7 +3842,7 @@ int mg_set_leaf_id(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 int mg_get_local_EKB(struct scsi_cmnd *srb, struct rtsx_chip *chip)
-	int retval = STATUS_FAIL;
+	int retval;
 	int bufflen;
 	unsigned int lun = SCSI_LUN(srb);
 	u8 *buf = NULL;

More information about the devel mailing list