[PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue
Greg KH
gregkh at linuxfoundation.org
Sat Aug 17 07:00:37 UTC 2019
On Sat, Aug 17, 2019 at 02:54:26AM -0400, Matthew Hanzelik wrote:
> Fixed an unnamed parameter style issue.
>
> Signed-off-by: Matthew Hanzelik <matthew.hanzelik at gmail.com>
> ---
> drivers/staging/speakup/spk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index a2fc72c29894..afa64eb9afb4 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -189,7 +189,7 @@ struct spk_synth {
> void (*flush)(struct spk_synth *synth);
> int (*is_alive)(struct spk_synth *synth);
> int (*synth_adjust)(struct st_var_header *var);
> - void (*read_buff_add)(u_char);
> + void (*read_buff_add)(u_char *add);
You just changed the function prototype from taking a single character,
to taking a pointer to a character, are you sure this is correct?
No other build warnings with this patch enabled?
thanks,
greg k-h
More information about the devel
mailing list