[PATCH v3 1/2] binder: Add default binder devices through binderfs when configured

Christian Brauner christian.brauner at ubuntu.com
Fri Aug 9 18:22:17 UTC 2019


On Fri, Aug 09, 2019 at 04:50:16PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 08, 2019 at 03:27:25PM -0700, Hridya Valsaraju wrote:
> > Currently, since each binderfs instance needs its own
> > private binder devices, every time a binderfs instance is
> > mounted, all the default binder devices need to be created
> > via the BINDER_CTL_ADD IOCTL.
> 
> Wasn't that a design goal of binderfs?

Sure, but if you solely rely binderfs to be used to provide binder
devices having them pre-created on each mount makes quite some sense,
imho.

> 
> > This patch aims to
> > add a solution to automatically create the default binder
> > devices for each binderfs instance that gets mounted.
> > To achieve this goal, when CONFIG_ANDROID_BINDERFS is set,
> > the default binder devices specified by CONFIG_ANDROID_BINDER_DEVICES
> > are created in each binderfs instance instead of global devices
> > being created by the binder driver.
> 
> This is going to change how things work today, what is going to break
> because of this change?
> 
> I don't object to this, except for the worry of changing the default
> behavior.

This is something that Hridya and Todd can speak better to given that
they suggested this change. :)
>From my perspective, binderfs binder devices and the regular binder
driver are mostly used mutually exclusive in practice atm so that this
change has little chance of breaking anyone.

Now I really need to go back to vacation time - which I suck at
apparently. :)

Christian


More information about the devel mailing list