[PATCH 07/10] staging: rtl8712: init_drv_sw(): Change return values

[Dan Carpenter]

On Thu, Aug 08, 2019 at 12:10:09PM +0530, Nishka Dasgupta wrote:
> -	if (_r8712_init_sta_priv(&padapter->stapriv))
> -		return _FAIL;
> +	ret = _r8712_init_sta_priv(&padapter->stapriv);
> +	if (ret)
> +		return ret;
>  	padapter->stapriv.padapter = padapter;
>  	r8712_init_bcmc_stainfo(padapter);
>  	r8712_init_pwrctrl_priv(padapter);
>  	mp871xinit(padapter);
>  	init_default_value(padapter);
>  	r8712_InitSwLeds(padapter);
> -	return _SUCCESS;
> +	return ret;

(Please don't resend.  I'd prefer if someone addressed this in a later
patch).  It's better to "return 0;" here because that's clear without
needing to read back a few lines to see what ret is.

regards,
dan carpenter