[PATCH 3/6] staging: wilc1000: remove unused members

Dan Carpenter dan.carpenter at oracle.com
Wed Aug 7 11:03:51 UTC 2019


On Tue, Aug 06, 2019 at 07:32:08PM +0000, Adham.Abozaeid at microchip.com wrote:
> Hi Dan
> 
> On 8/6/19 5:46 AM, Dan Carpenter wrote:
> > External E-Mail
> >
> >
> > On Thu, Jul 25, 2019 at 09:31:34PM +0000, Adham.Abozaeid at microchip.com wrote:
> >> From: Adham Abozaeid <adham.abozaeid at microchip.com>
> >>
> >> remove obtaining_ip from struct wilc_vif
> >>
> > How is this "unused"?  It looks like it is used to me.
> The main usage of obtaining_ip was to track the inetadd_notifier status.
> After removing the notifier and ip address timeout timer in the first and second patch,
> the remaining usage became meaningless, and could be removed.

This is exactly the level of detail that I would like in a commit
description.

regards,
dan carpenter



More information about the devel mailing list