[PATCH 2/2] staging: kpc2000_spi: eliminated duplicate initialization of master local variable.

Jeremy Sowden jeremy at azazel.net
Sat Apr 27 19:54:01 UTC 2019


master was being initialized to a particular value and then having the
same value assigned to it immediately afterwards.  Removed the
initializer.

Since the value assigned to master was dynamically allocated, this fixes
a memory-leak.

Signed-off-by: Jeremy Sowden <jeremy at azazel.net>
---
 drivers/staging/kpc2000/kpc_spi/spi_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/kpc2000/kpc_spi/spi_driver.c b/drivers/staging/kpc2000/kpc_spi/spi_driver.c
index e77f04bf02d9..c0999e080577 100644
--- a/drivers/staging/kpc2000/kpc_spi/spi_driver.c
+++ b/drivers/staging/kpc2000/kpc_spi/spi_driver.c
@@ -408,7 +408,7 @@ static int
 kp_spi_probe(struct platform_device *pldev)
 {
     struct kpc_core_device_platdata *drvdata;
-    struct spi_master *master = spi_alloc_master(&pldev->dev, sizeof(struct kp_spi));
+    struct spi_master *master;
     struct kp_spi *kpspi;
     struct resource *r;
     int status = 0;
-- 
2.20.1



More information about the devel mailing list