[PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT

Dan Carpenter dan.carpenter at oracle.com
Thu Apr 4 09:12:06 UTC 2019


On Wed, Apr 03, 2019 at 05:45:02PM -0300, Lucas Oshiro wrote:
>  #define AD7746_VTSETUP_VTMD_INT_TEMP	(0 << 5)
> -#define AD7746_VTSETUP_VTMD_EXT_TEMP	(1 << 5)
> +#define AD7746_VTSETUP_VTMD_EXT_TEMP	BIT(5)

No, the original is more readable.  Otherwise you can't see that it's
part of a set.

Just ignore checkpatch when it gives nonsense advice.

regards,
dan carpenter



More information about the devel mailing list