[PATCH v2] staging: vc04_services: Update TODO re: arm64
Aymen Qader
qader.aymen at gmail.com
Mon Sep 24 23:34:26 UTC 2018
Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:
(7e8dbdea) staging: bcm2835-camera: Remove explicit cache flush
operations
Also remove the unnecessary asm/cacheflush.h header.
Signed-off-by: Aymen Qader <qader.aymen at gmail.com>
---
v2: Make commit message clearer
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
index cefce72d814f..6c2b4ffe4996 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/TODO
+++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the
hardware can do. If we exposed the native padding requirements
through the V4L2 "multiplanar" formats, the firmware would have one
less copy it needed to do.
-
-3) Port to ARM64
-
-The bulk_receive() does some manual cache flushing that are 32-bit ARM
-only, which we should convert to proper cross-platform APIs.
-
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
index 51e5b04ff0f5..6e5c1d4ee122 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
@@ -21,7 +21,6 @@
#include <linux/slab.h>
#include <linux/completion.h>
#include <linux/vmalloc.h>
-#include <asm/cacheflush.h>
#include <media/videobuf2-vmalloc.h>
#include "mmal-common.h"
--
2.17.1
More information about the devel
mailing list