[PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested

KY Srinivasan kys at microsoft.com
Mon Sep 17 15:25:21 UTC 2018



> -----Original Message-----
> From: Greg KH <gregkh at linuxfoundation.org>
> Sent: Monday, September 17, 2018 7:28 AM
> To: KY Srinivasan <kys at microsoft.com>
> Cc: olaf at aepfle.de; Stephen Hemminger <sthemmin at microsoft.com>;
> jasowang at redhat.com; linux-kernel at vger.kernel.org; Michael Kelley
> (EOSG) <Michael.H.Kelley at microsoft.com>; apw at canonical.com;
> devel at linuxdriverproject.org; vkuznets <vkuznets at redhat.com>
> Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
> operation was requested
> 
> On Mon, Sep 17, 2018 at 02:16:48PM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh at linuxfoundation.org>
> > > Sent: Sunday, September 16, 2018 9:56 PM
> > > To: KY Srinivasan <kys at microsoft.com>
> > > Cc: linux-kernel at vger.kernel.org; devel at linuxdriverproject.org;
> > > olaf at aepfle.de; apw at canonical.com; jasowang at redhat.com; Stephen
> > > Hemminger <sthemmin at microsoft.com>; Michael Kelley (EOSG)
> > > <Michael.H.Kelley at microsoft.com>; vkuznets <vkuznets at redhat.com>
> > > Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
> > > operation was requested
> > >
> > > On Mon, Sep 17, 2018 at 04:14:55AM +0000, kys at linuxonhyperv.com
> wrote:
> > > > From: Vitaly Kuznetsov <vkuznets at redhat.com>
> > > >
> > > > 'error' variable is left uninitialized in case we see an unknown operation.
> > > > As we don't immediately return and proceed to pwrite() we need to set
> it
> > > > to something, HV_E_FAIL sounds good enough.
> > > >
> > > > Signed-off-by: Vitaly Kuznetsov <vkuznets at redhat.com>
> > > > Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> > > > ---
> > > >  tools/hv/hv_fcopy_daemon.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > >
> > > No need to backport for stable?
> > Thanks for pointing this out. Should I resubmit with the stable tag?
> 
> I can do it... :)
Thank you!

K. Y


More information about the devel mailing list