[PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c
Michael Straube
straube.linux at gmail.com
Wed Sep 5 11:44:43 UTC 2018
On 9/5/18 10:13 AM, Dan Carpenter wrote:
> On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote:
>>
>> case LED_CTL_SITE_SURVEY:
>> - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) {
>> - ;
>> - } else if (!pLed->bLedScanBlinkInProgress) {
>> + if (!pLed->bLedScanBlinkInProgress) {
>
> I think you have introduced a bug...
Ah yes I see now, thanks.
Would it be ok to merge the conditions in a single if?
if ((!pmlmepriv->LinkDetectInfo.bBusyTraffic ||
!check_fwstate(pmlmepriv, _FW_LINKED)) &&
!pLed->bLedScanBlinkInProgress) {
regards,
Michael
More information about the devel
mailing list